Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/boost issue #713

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Fix/boost issue #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfc77b7
fixed inhertance
dellaert Mar 11, 2021
c37c8b7
Added explicit header as suggested in issue #634
dellaert Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gtsam/gtsam.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1809,7 +1809,7 @@ class GaussianFactorGraph {
};

#include <gtsam/linear/GaussianConditional.h>
virtual class GaussianConditional : gtsam::GaussianFactor {
virtual class GaussianConditional : gtsam::JacobianFactor {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the super class for this? Doesn't GaussianFactor make sense for a GaussianConditional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JacobianFactor is in turn a GaussianFactor

//Constructors
GaussianConditional(size_t key, Vector d, Matrix R, const gtsam::noiseModel::Diagonal* sigmas);
GaussianConditional(size_t key, Vector d, Matrix R, size_t name1, Matrix S,
Expand Down
1 change: 1 addition & 0 deletions gtsam/linear/LossFunctions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include <boost/serialization/optional.hpp>
#include <boost/serialization/shared_ptr.hpp>
#include <boost/serialization/singleton.hpp>
#include <boost/serialization/version.hpp>

namespace gtsam {
namespace noiseModel {
Expand Down
1 change: 1 addition & 0 deletions gtsam/linear/SubgraphBuilder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

#include <boost/serialization/nvp.hpp>
#include <boost/shared_ptr.hpp>
#include <boost/serialization/version.hpp>

#include <vector>

Expand Down