Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding factor which considers the essential matrix and camera calibration as variable #753
Adding factor which considers the essential matrix and camera calibration as variable #753
Changes from 1 commit
8ca7f1f
f60e9e9
64ff24b
b00046c
b0fb6a3
bd0838c
2cf76da
4572282
71b9004
bf93f17
b3601ef
4fbd98d
8a2ce7e
0ecd8ab
ae69e5f
582afe1
15f8b41
e9738c7
65211f8
2e69d09
2e8bfd6
91e58f5
bce9050
620bcf7
f1ea57a
14f8b8a
285f041
373b109
01515d1
c458294
545dfd0
d9a8111
47f9f30
e3b6c83
a69f9e5
119e43a
01561bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, guys. should we give a definition for what range constitutes a "very low" sigma?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is relative, it depends on the sigma that is not low. There are examples in the unit tests, which are still empirical. Not sure if there is an accurate answer that can be briefly documented.