Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Error message for TBB handling with versions greater than 2021.1 on OS X #876

Merged
merged 3 commits into from
Sep 20, 2021

Conversation

akashsharma02
Copy link
Contributor

Updated FindTBB.cmake to find version file appropriately on Mac OS X.
Since oneTBB API is not supported, added a better error message to use an older version for now.

Better Error message for TBB handling with versions greater than 2021.1
on OS X
@akashsharma02
Copy link
Contributor Author

@varunagrawal / @dellaert Could you please review the PR?
BTW, Is there a plan in the future to support oneTBB?

Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Thanks for the PR @akashsharma02

@varunagrawal
Copy link
Collaborator

@akashsharma02 can you please merge the latest develop and resolve the conflicts? We can then merge this in.

@varunagrawal varunagrawal added bugfix Fixes an issue or bug cmake Related to CMake and build system labels Sep 19, 2021
@varunagrawal varunagrawal merged commit b4b2f41 into borglab:develop Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes an issue or bug cmake Related to CMake and build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants