This repository has been archived by the owner on Feb 13, 2025. It is now read-only.
cmd/bosun: Add over, shift, and merge funcs #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebrandt
force-pushed
the
shiftMerge
branch
2 times, most recently
from
3bcb08d to
de71677
Compare
| @@ -371,6 +396,43 @@ func Filter(e *State, T miniprofiler.Timer, series *Results, number *Results) (* | |||
| return series, nil | |||
| } | |||
|
|
|||
| func Merge(e *State, T miniprofiler.Timer, series ...*Results) (*Results, error) { | |||
| if len(series) < 1 { | |||
There was a problem hiding this comment.
I'd prefer == 0 and == 1 for these two short circuit clauses.
This adds the ability to graph multiple seriesSets in expression graphs, and also graph things like week-over-week. Fixes #985
kylebrandt
force-pushed
the
shiftMerge
branch
from
de71677 to
3bdc6da
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to graph multiple seriesSets in expression graphs, and also graph things like week-over-week.