Support posargs to tox #1066
Support posargs to tox #1066
Conversation
scripts/ci/run-tests
Outdated
| @@ -16,5 +17,10 @@ def run(command): | |||
| return check_call(command, shell=True) | |||
|
|
|||
|
|
|||
| _, args = OptionParser(usage="%prog TEST_DIR ...").parse_args() | |||
There was a problem hiding this comment.
To make this simpler, I would probably just pass sys.argv through to the underlying command instead of trying to parse arguments here, defaulting to just unit/ functional/ if sys.argv is empty.
|
Other than the change to using |
|
I don't know if OptionParser is really any more complicated than reading sys.argv, and you get some help text for free to boot, but I don't have strong opinions either way. The bigger simplification was ditching the shell=True kwarg, which means we don't have to worry about arg quoting. |
|
The simplification was largely that it allows you to pass additional things besides paths to the script now as well. |
|
Good point. For some reason I was thinking OptionParser() passed through unknown flags as posargs, but that's not the behavior now that I check. Thanks for the review. |
|
Thanks! |
* release-1.4.5: (23 commits) Bumping version to 1.4.5 Add release note entry for LifecycleConfiguration Add LifecycleConfiguration resource Backward compatible bug fix for typo in MultipartUploads (#1142) Fix example in doc (#1158) Assert that unsigned resources stay unsigned s/paramter/parameter/ Update docs for multiprocessing Rename [wheel] section to [bdist_wheel] as the former is legacy (#1112) added s3 download_file doc example (#1098) Allow Bucket.load() to work on cross-account buckets (#1064) Support posargs to tox (#1066) 5x5 (#1050) Fix minor typo brought up in #1026 (#1027) Do not log call parameters on info level Update doc tests Update transfer.py (#1016) Fix typo in return type annotation Add new change types. (#992) Changed an info log to a debug log ...
Currently tox will always run all tests, which contradicts the README.