Update docs for multiprocessing #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
added
the
pr/needs-review
dstufft
reviewed
Jun 6, 2017
docs/source/guide/resources.rst
Outdated
| It is recommended to create a resource instance for each thread in a multithreaded application rather than sharing a single instance among the threads. For example:: | ||
| Multithreading / Multiprocessing | ||
| -------------------------------- | ||
| It is recommended to create a resource instance for each thread / process in a multithreaded application rather than sharing a single instance among the threads / processes. For example:: |
There was a problem hiding this comment.
Should this say "in a multi threaded or multi process application"?
Our docs already give advice about multithreading, but did not give any advice about multiprocessing. This explicitly calls out that the reccomendations for multithreading and multiprocessing are the same.
JordonPhillips
force-pushed
the
multiprocessing-doc
branch
from
676fdad to
12e21f0
Compare
dstufft
approved these changes
Jun 6, 2017
stealthycoin
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our docs already give advice about multithreading, but did not give
any advice about multiprocessing. This explicitly calls out that the
reccomendations for multithreading and multiprocessing are the same.
cc @kyleknap @jamesls @stealthycoin @dstufft