Add custom load() for s3.Bucket #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test fixed. Should be ready to look at now. |
|
|
||
|
|
||
| def bucket_load(self, *args, **kwargs): | ||
| """Fake s3.Bucket.load method. |
There was a problem hiding this comment.
If this is a custom method, I will use this docstring because it is not modeled in the resource model.
I have been auto-documenting the load and reload methods as the following:
Calls [service].Client.[method]() to update the attributes of the [name_of_resource] resource.
So maybe do it as?
Calls s3.Client.list_objects() to update the attributes of the Object resource.
Then you can move the original docstring to a comment or into the inject method.
Let me know what you think.
There was a problem hiding this comment.
Sounds good, I'll update.
|
Looks good. I just had a few comments. 🚢 |
|
Feedback incorporated. |
|
Thanks. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like some feedback on whether we want this change. This is proposed from #102.
It does solve the problem that you will no longer get a confusing error when accessing
bucket.creation_date, but we have to make a ListBuckets requests to get this information.cc @kyleknap @mtdowling @trevorrowe