-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for python 3.8 #1922
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1922 +/- ##
===========================================
+ Coverage 92.66% 92.79% +0.13%
===========================================
Files 53 53
Lines 10175 10332 +157
===========================================
+ Hits 9429 9588 +159
+ Misses 746 744 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should properly support 3.8 this and not just let the misc. warnings propagate. I think we build on https://github.com/boto/botocore/pull/1865/files as part of this change. Only thing I'd change in that PR is moving the try/except into compat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move the imports to compat.py and then we should be good.
botocore/awsrequest.py
Outdated
@@ -29,6 +28,11 @@ | |||
urlencode | |||
from botocore.exceptions import UnseekableStreamError | |||
|
|||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I was referring to when I mentioned moving the try/except into a compat module. It's repeated 3 times and is a perfect fit for compat.py
.
@joguSD Updated compat module, should be ready to look at again. Just waiting for travis to pass. |
No description provided.