Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for python 3.8 #1922

Merged
merged 4 commits into from
Dec 20, 2019
Merged

Add support for python 3.8 #1922

merged 4 commits into from
Dec 20, 2019

Conversation

stealthycoin
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #1922 into develop will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1922      +/-   ##
===========================================
+ Coverage    92.66%   92.79%   +0.13%     
===========================================
  Files           53       53              
  Lines        10175    10332     +157     
===========================================
+ Hits          9429     9588     +159     
+ Misses         746      744       -2
Impacted Files Coverage Δ
botocore/session.py 98.13% <100%> (+0.01%) ⬆️
botocore/awsrequest.py 98.37% <100%> (+0.01%) ⬆️
botocore/compat.py 94.11% <100%> (+0.19%) ⬆️
botocore/signers.py 98.11% <0%> (-0.42%) ⬇️
botocore/config.py 100% <0%> (ø) ⬆️
botocore/discovery.py 100% <0%> (ø) ⬆️
botocore/eventstream.py 100% <0%> (ø) ⬆️
botocore/args.py 100% <0%> (ø) ⬆️
botocore/configprovider.py 93.37% <0%> (ø) ⬆️
botocore/parsers.py 99.79% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5438535...ebd12d8. Read the comment docs.

Copy link
Member

@jamesls jamesls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should properly support 3.8 this and not just let the misc. warnings propagate. I think we build on https://github.com/boto/botocore/pull/1865/files as part of this change. Only thing I'd change in that PR is moving the try/except into compat.

Copy link
Member

@jamesls jamesls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the imports to compat.py and then we should be good.

@@ -29,6 +28,11 @@
urlencode
from botocore.exceptions import UnseekableStreamError

try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I was referring to when I mentioned moving the try/except into a compat module. It's repeated 3 times and is a perfect fit for compat.py.

@jamesls
Copy link
Member

jamesls commented Dec 20, 2019

@joguSD Updated compat module, should be ready to look at again. Just waiting for travis to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants