kubernetes: move dockershim link to relative path #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: bottlerocket-os/bottlerocket#4074
Closes # bottlerocket-os/bottlerocket#4074
Description of changes:
The link created for dockershim.sock was an absolute path which worked fine until that link is mounted into a container under a different path. This would break use cases where the container needs to follow that link to get to the containerd socket. This commit moves to a relative symlink so that this will work via paths such as /host/run/dockershim.sock.
Testing done:
I tested the specific use case of datadog where the agent code was failing to follow the link, before:
after this change, the agent doesn't emit this failure.
The link can be followed now from within the container, before:
after:
You can still use the file from within the host as well:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.