Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and improve GitHub cache action #2

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

bcressey
Copy link
Contributor

Issue number:
Failure observed after merging the first PR.

Description of changes:
The previous cache action failed because Makefile.toml was removed from the kit. Switch it to use the Makefile targets instead.

While we're at it, modify the cache action to cache Rust and Go deps, to see if this helps to speed up builds.

Testing done:
Ran through the make steps locally.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@bcressey bcressey requested review from arnaldo2792 and yeazelm June 15, 2024 03:04
@larvacea
Copy link
Member

All checks have failed: one of those cache actions does not have the required key parameter.

The previous cache action failed because `Makefile.toml` was removed
from the kit. Switch it to use the Makefile targets instead.

While we're at it, modify the cache action to cache Rust and Go deps,
to see if this helps to speed up builds.

Signed-off-by: Ben Cressey <[email protected]>
Copy link
Member

@larvacea larvacea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. I am a fan. I've been running multiple cache actions for years on my own tiny app.

@bcressey bcressey merged commit 171c24f into bottlerocket-os:develop Jun 16, 2024
2 checks passed
@bcressey bcressey deleted the fix-cache branch June 16, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants