Label additional FIPS binaries #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix label for `migrator`, `cfsignal` and `shibaken` when the FIPS binaries from `/usr/fips/` are used Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
bcressey
approved these changes
Oct 26, 2024
ginglis13
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related: bottlerocket-os/bottlerocket#1667
Description of changes:
The FIPS binaries created for
migrator,cfsignalandshibakenreceived the wrong label. Formigrator, upgrades failed with an SELinux denial:Testing done:
aws-k8s-1.30-fips(defined in my local BoB repo) boots and joins a clusteraws-k8s-1.30-fipssuccessfully performs in-place upgradesTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.