-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package: add rdma-core #223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63cc379
to
4ad9072
Compare
arnaldo2792
requested changes
Oct 28, 2024
bcressey
reviewed
Oct 31, 2024
4ad9072
to
c7c8a5f
Compare
c7c8a5f
to
a95dbdd
Compare
bcressey
approved these changes
Nov 1, 2024
d288737
to
4c6d72c
Compare
bcressey
approved these changes
Nov 5, 2024
4c6d72c
to
cc4be4e
Compare
- Add minimum required libraries and drivers in libibverbs. - Add helper program ibv_devices and ibv_devinfo Signed-off-by: Yutong Sun <[email protected]>
Signed-off-by: Yutong Sun <[email protected]>
cc4be4e
to
10eb549
Compare
arnaldo2792
approved these changes
Nov 6, 2024
%{cross_cmake} . \ | ||
-DNO_PYVERBS=1 \ | ||
-DNO_MAN_PAGES=1 \ | ||
-DCMAKE_BUILD_TYPE=Release \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you don't need to set CMAKE_BUILD_TYPE=Release
, it is already set by cross_cmake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related to bottlerocket-os/bottlerocket#1031
Description of changes:
Add
rdma-core
package to core-kit. This is part of the effort to fully support EFA in Bottlerocket first party AMI. We will use the helper programs provided by rdma-core for better troubleshoot and logging experience (will be added in follow up PR).ibv_devices
andibv_devinfo
libibverbs
.Testing done:
aws-k8s-1.28-nvidia
and tested the helper binary.logdog
command indicates the rdma-core related logs are producedUnzipped the log file and verified the contents:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.