allow overriding the max-pods file with one from your variant #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files in RPMs can't conflict, so we modify pluto to read from a normally non-existent override file. A variant can then write this file to override the default max-pod provided by the core-kit.
tzneal
force-pushed
the
allow-overriding-max-pods
branch
2 times, most recently
from
67a0aba to
07e2934
Compare
bcressey
approved these changes
Nov 19, 2024
bcressey
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #
Description of changes:
Files in RPMs can't conflict, so we modify pluto to read from a normally non-existent min & max file. A variant can then write this file to override an absolute min/max number of pods per node.
Testing done:
Built a custom variant with a eni-max-pods-max file
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.