build: fix aws-iam-authenticator build #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
approved these changes
May 4, 2022
jpculp
approved these changes
May 4, 2022
Dockerfile
Outdated
Comment on lines
194
to
195
| ARG AWS_IAM_AUTHENTICATOR_SHA512_SUM=24c2a7fd141f921e18c17f4c7e90bbf5325cc6fad3b35753c0da2d879cf64d8f6af0130f8c45ec7693d6fce043181abbd04a911e6fa778f686bd5c313631ed0f | ||
| ARG AWS_IAM_AUTHENTICATOR_SOURCE_URL="https://cache.bottlerocket.aws/aws-iam-authenticator-0.5.5.tar.gz/${AWS_IAM_AUTHENTICATOR_SHA512_SUM}/aws-iam-authenticator-${AWS_IAM_AUTHENTICATOR_VERSION}.tar.gz" |
There was a problem hiding this comment.
I don't have strong feelings about this, but should we take the sdk-fetch/hashes approach that we're using with the other Bottlerocket containers?
There was a problem hiding this comment.
Hmm, probably, I would need to find a prototype example. Are these in the Bottlerocfket rpm spec files?
There was a problem hiding this comment.
This is probably the most straight forward example: bottlerocket-os/bottlerocket-admin-container#35
There was a problem hiding this comment.
I'm going to leave sdk-fetch as a future enhancement. It seems like it makes the most sense when you have all of your sources in the lookaside cache.
Apparently, GitHub archive hashes are not stable. The sha sum for aws-iam-authenticator changed and it broke our build. Now we pull it from the Bottlerocket lookaside cache instead.
|
^ We need to use 0.5.3 to avoid a breaking change for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N.A
Description of changes:
Apparently, GitHub archive hashes are not stable. The sha sum for
aws-iam-authenticator changed and it broke our build. Now we pull it
from the Bottlerocket lookaside cache instead.
We probably need to do something like this with the rest of our GitHub archive sourcecode pulls as well, but for now this fixes our build.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.