Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsys: Add test type for cluster templating #137

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

ecpullen
Copy link
Contributor

@ecpullen ecpullen commented Jan 23, 2024

Issue number:

Closes #N/A

Description of changes:

Adds 2 additional fields for templating cluster config files. This allows us to provision separate clusters for each test type.

apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig
metadata:
  name: "{{kube-arch}}-{{kube-variant}}-ipv6-{{test-flavor}}"
  version: "{{version}}"
  region: "us-west-2"
kubernetesNetworkConfig:
  ipFamily: IPv6

Testing done:

TBA

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@ecpullen ecpullen requested a review from webern January 23, 2024 18:04
@ecpullen ecpullen requested a review from rpkelly January 24, 2024 22:00
Copy link
Contributor

@arnaldo2792 arnaldo2792 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks might be already familiar with how this change affects testsys, but it will be nice to add a line or two on the PR description to help reviewers understand why this is needed or how this will improve the testsys experience.

@@ -488,6 +488,11 @@ pub(crate) trait CrdCreator: Sync {
.into_iter()
// Add the image id in case it is needed for cluster creation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should reflect the change

@ecpullen ecpullen marked this pull request as ready for review January 29, 2024 23:53
@ecpullen ecpullen merged commit a3b6477 into bottlerocket-os:develop Jan 30, 2024
1 check passed
@ecpullen ecpullen deleted the custom-configs branch January 30, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants