rpm2img: use openssl to generate HMAC #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `sha512hmac` tool from libkcapi requires the kernel to be built with CRYPTO_USER support. If this dependency is not satisfied, the signature generation fails with this message: Error: Netlink error: sendmsg failed Error: NETLINK_CRYPTO: cannot obtain cipher information for hmac(sha512) Generate the HMAC with `openssl` instead, which does not require any specific kernel functionality. Signed-off-by: Ben Cressey <[email protected]>
arnaldo2792
approved these changes
Apr 10, 2024
jpculp
approved these changes
Apr 10, 2024
sumukhballal
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #195
Description of changes:
The
sha512hmactool from libkcapi requires the kernel to be built with CRYPTO_USER support. If this dependency is not satisfied, the signature generation fails with this message:Generate the HMAC with
opensslinstead, which does not require any specific kernel functionality.Testing done:
Verified that the generated HMAC can be validated at runtime with
sha512hmac:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.