rpm2img: move OVA generation to imghelper #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick J.P. Culp <[email protected]>
jpculp
commented
May 15, 2024
| local ovf_template uefi_secure_boot sbkeys output_dir | ||
| ovf_template="${5:?}" | ||
| uefi_secure_boot="${6:?}" | ||
| sbkeys="${7:?}" |
There was a problem hiding this comment.
sbkeys will eventually be a constant in imghelper, but I'll switch this when the secure boot code moves over.
rpkelly
reviewed
May 15, 2024
bcressey
approved these changes
May 15, 2024
rpkelly
approved these changes
May 15, 2024
webern
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Relocates code-block that created the OVA to
imghelper. Small changes include localizing of variables and adding|| exit 1topushd/popdsinceimghelperdoesn't assumeset -eis set in the calling script.Testing done:
vmware-k8s-1.28.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.