test-project: fixes for development of kits functionality #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
force-pushed
the
variant-insensitive
branch
from
d013781 to
9da417b
Compare
webern
force-pushed
the
kit-project-fixes
branch
2 times, most recently
from
fa1f52f to
b733d4c
Compare
webern
changed the title
bcressey
approved these changes
May 20, 2024
In order for the test project to work, we need to use a recent and compatible Bottlerocket SDK.
The build system's expectations when re-naming a package are a bit particular. The spec file and the directory must conform to the "override" name. This commit gives the test project that does this by simulating the naming convention used by Bottlerocket's Kubernetes packages.
Because the build system currently mounts sources/models/src/variant, we need this directory to exist in our project. When conditional compilation of the model is no longer taking place, the directory will no longer need to be mounted in the build's Dockerfile and this .keep file can be removed.
Until #120 is done, we need the generate-sbkeys-script to exist in the right place in the project even if we are not using its functionality.
webern
force-pushed
the
variant-insensitive
branch
from
9da417b to
f11b56c
Compare
|
Oops. Didn't mean to close it. Re-opening. |
bcressey
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Follows #220 (technically it doesn't need to but chaining it into the
variant-insensitivebranch helps me built up all the code I need to merge and this is an easy-to-review unit in that chain)Description of changes:
Fixes to the test project that I need to make kit development work.
Testing done:
In subsequent work I was able to build a kit.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.