alpha-sdk: add dockerignore #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
May 24, 2024
jpculp
reviewed
May 24, 2024
| @@ -171,7 +171,7 @@ do | |||
| --tag "${tag}" \ | |||
| --build-arg "SDK=${sdk}" \ | |||
| --build-arg "HOST_GOARCH=${host_arch}" \ | |||
| --file "${script_dir}/alpha-sdk.dockerfile" \ | |||
There was a problem hiding this comment.
I recently broke up the Dockerfile used by buildsys to be:
build.Dockerfile
build.Dockerfile.dockerignore
repack.Dockerfile
repack.Dockerfile.dockerignore
Should this be alpha-sdk.Dockerfile and alpha-sdk.Dockerfile.dockerignore instead?
There was a problem hiding this comment.
Do you mean the casing is wrong? Yeah I can make it uppercase.
webern
force-pushed
the
alpha-sdk-dockerignore
branch
from
9d1657c to
a44f478
Compare
|
Change dockerfile naming convention to match other dockerfiles. |
jpculp
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related #210
Description of changes:
Without this change the per-package directory structure would cause all RPMs to be missing from the Alpha SDK because Bottlerocket's
.dockerignorefile would ignore them. With this change we create a.dockerignoreto be used when building the Alpha SDK.Testing done:
Built an Alpha SDK and verified that the RPMs were copied to it.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.