Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twoliter: fix sdk inspect handling #285

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

jmt-lab
Copy link
Contributor

@jmt-lab jmt-lab commented Jun 13, 2024

Description of changes:

Fixes issue with locked image trying to inspect manifest for sdk

Closes #284
Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jmt-lab jmt-lab self-assigned this Jun 13, 2024
@jmt-lab
Copy link
Contributor Author

jmt-lab commented Jun 13, 2024

run_test.sh does

cargo run -p twoliter --bin twoliter -- $@ --project-path /home/fedora/twoliter/tests/projects/local-kit/Twoliter.toml
[fedora@ip-172-31-32-163 twoliter]$ ./run_test.sh update
   Compiling twoliter v0.2.0 (/home/fedora/twoliter/twoliter)
   Compiling buildsys v0.1.0 (/home/fedora/twoliter/tools/buildsys)
   Compiling pubsys v0.1.0 (/home/fedora/twoliter/tools/pubsys)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 46.18s
     Running `target/debug/twoliter update --project-path /home/fedora/twoliter/tests/projects/local-kit/Twoliter.toml`
[fedora@ip-172-31-32-163 twoliter]$ ./run_test.sh fetch --arch aarch64
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.19s
     Running `target/debug/twoliter fetch --arch aarch64 --project-path /home/fedora/twoliter/tests/projects/local-kit/Twoliter.toml`
./run_test.sh build kit core-kit --arch aarch64
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.20s
     Running `target/debug/twoliter build kit core-kit --arch aarch64 --project-path /home/fedora/twoliter/tests/projects/local-kit/Twoliter.toml`
[cargo-make] INFO - cargo make 0.37.12
[cargo-make] INFO - Calling cargo metadata to extract project info
[cargo-make] INFO - Cargo metadata done
[cargo-make] INFO - Build File: /home/fedora/twoliter/tests/projects/local-kit/build/tools/Makefile.toml
[cargo-make] INFO - Task: build-kit
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: check-cargo-version
[cargo-make] INFO - Running Task: setup
[cargo-make] INFO - Running Task: setup-build
[cargo-make] INFO - Running Task: fetch-sdk
[cargo-make] INFO - Running Task: fetch-sources
[cargo-make] INFO - Running Task: fetch-vendored
go: no dependencies to vendor
[cargo-make] INFO - Running Task: publish-setup
17:08:39 [INFO] No infra config at '/home/fedora/twoliter/tests/projects/local-kit/Infra.toml' - using local roles/keys
[cargo-make] INFO - Running Task: cargo-metadata
[cargo-make] INFO - Running Task: build-kit
ManifestParse
   Compiling pkg-a-1_27 v0.1.0 (/home/fedora/twoliter/tests/projects/local-kit/packages/pkg-a-1.27)
   Compiling core-kit v0.1.0 (/home/fedora/twoliter/tests/projects/local-kit/kits/core-kit)
    Finished `dev` profile [optimized] target(s) in 12.43s
[cargo-make] INFO - Build Done in 16.65 seconds.

webern
webern previously requested changes Jun 13, 2024
Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI reveals a similar issue (or the same issue) as the one being fixed... also, I think maybe I was seeing this transiently locally yesterday?

called `Result::unwrap()` on an `Err` value: failed to inspect manifest of resource at public.ecr.aws/bottlerocket/bottlerocket-sdk:v0.41.0

twoliter/src/lock.rs Outdated Show resolved Hide resolved
@jmt-lab jmt-lab dismissed webern’s stale review June 13, 2024 19:04

Simple change, matt is already aware of it

@jmt-lab jmt-lab merged commit 0e48961 into bottlerocket-os:develop Jun 13, 2024
1 check passed
@jmt-lab jmt-lab deleted the ootb/fix branch June 13, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

twoliter treats SDK images as if they were a kit
4 participants