Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bye bye alpha sdk #286

Merged
merged 2 commits into from
Jun 13, 2024
Merged

bye bye alpha sdk #286

merged 2 commits into from
Jun 13, 2024

Conversation

webern
Copy link
Contributor

@webern webern commented Jun 13, 2024

Issue number:

Closes #113

Description of changes:

Stop using the Alpha SDK for twoliter build variant.

Testing done:

  • Build Bottlerocket (using twoliter build variant for the first time!)

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

webern added 2 commits June 13, 2024 13:10
We no longer need to build and use Alpha SDKs because kits are now
implemented.
Stop expecting the Alpha SDK for twoliter build variant.
@webern
Copy link
Contributor Author

webern commented Jun 13, 2024

Bottlerocket build seems to be working. But we seem to be rebuilding everything every time (unrelated to this PR).

@webern webern marked this pull request as ready for review June 13, 2024 21:12
@webern webern merged commit 3d79406 into bottlerocket-os:develop Jun 13, 2024
1 check passed
@webern webern deleted the no-alpha-sdk branch June 13, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alpha: Find a better solution for models mount
3 participants