get rid of the ManifestParse printout #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of errors had no display in the bottlerocket-variant binary.
Variant environment variables are no longer needed when building a kit or a package.
webern
force-pushed
the
manifest-parse-error
branch
from
8fa9c1b to
3482bc8
Compare
bcressey
approved these changes
Jun 18, 2024
cbgbt
approved these changes
Jun 18, 2024
bcressey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
We were seeing
ManifestParsein the output when building a kit. This was fromeval $(bottlerocket-variant)which was hitting an error because the variantCargo.tomldidn't exist.This PR fixes the missing error message and stops running
bottlerocket-variantwhen it's not needed.Testing done:
Build a test kit, saw
ManifestParseAfter fixing the error message, did the same and saw the actual error message.
Removed the
bottlerocket-variantcalls frombuild-kitandbuild-packageand no longer saw an error message.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.