revert application-inventory: use RPM's Version and Release, set Epoch #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert most of bottlerocket-os#263, which set the Epoch for packages built with Twoliter, set package inventory Version as the actual package version, and built a customer release field to give to the package. This PR retains the change to setting Release in the actual package RPM but reverts the change to include that in the application inventory for the package. Signed-off-by: Gavin Inglis <[email protected]>
yeazelm
approved these changes
Jun 18, 2024
arnaldo2792
approved these changes
Jun 18, 2024
cbgbt
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
revert most of #263, which set the Epoch for packages built with Twoliter, set package inventory Version as the actual package version, and built a customer release field to give to the package.
This PR retains the change to setting Release in the actual package RPM but reverts the change to include that in the application inventory for the package.
Testing done:
cargo make testBuild a variant and check that application inventory is generated as was prior.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.