twoliter: add support for crane #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbgbt
reviewed
Jun 19, 2024
jmt-lab
force-pushed
the
crane-support
branch
11 times, most recently
from
74ba77e to
74cfe60
Compare
|
Working on fixing the duplicate collision |
sam-berning
reviewed
Jun 21, 2024
jmt-lab
force-pushed
the
crane-support
branch
3 times, most recently
from
882a53f to
2a01bef
Compare
bcressey
reviewed
Jun 24, 2024
jmt-lab
force-pushed
the
crane-support
branch
2 times, most recently
from
7bc5aaf to
5f37fa3
Compare
bcressey
approved these changes
Jun 25, 2024
jmt-lab
force-pushed
the
crane-support
branch
3 times, most recently
from
bcb4e30 to
04055b9
Compare
sam-berning
approved these changes
Jun 25, 2024
|
Fixed caching of kit images and overuse of temp directories. Reran tests with both docker and crane ensuring caching and the expected directory works |
|
Fix comments per bens comments |
sam-berning
approved these changes
Jun 25, 2024
sam-berning
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Testing done:
Testing is still underway, building core kit locally to use for tests on my dev instance
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.