Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GTK4 and libadwaita #610

Closed
3 of 7 tasks
mirkobrombin opened this issue Oct 10, 2021 · 13 comments · Fixed by #1426
Closed
3 of 7 tasks

Move to GTK4 and libadwaita #610

mirkobrombin opened this issue Oct 10, 2021 · 13 comments · Fixed by #1426

Comments

@mirkobrombin
Copy link
Member

mirkobrombin commented Oct 10, 2021

GTK4 and Libadwaita is now supported by a large number of distributions.

Some distributions may not offer libadwaita out of the box (or at all) but I don't see a limitation, as we provide the flatpak, appimage and snap version for these reasons as well.

Blocking stuff

  • WebKit GTK4 support
  • WebKit 2.31+ in GNOME SDK (Flatpak)

Not blocking but good to have

Todo

  • f85befd Refactor details.ui, splitting in multiple files to make it much easy to understand and update
  • Remove deprecated stuff and Glade references
  • Set GTK namespace to 4.0 and replace Handy 1 with Adw 1
  • Fix all occurrences
@mirkobrombin mirkobrombin changed the title Move to GTK4 and libadwaita [Blocked] Move to GTK4 and libadwaita Oct 10, 2021
@jannuary
Copy link
Contributor

WebKit 2.31+ in GNOME SDK (Flatpak)

GNOME Master SDK now includes WebKit.

@mirkobrombin
Copy link
Member Author

mirkobrombin commented Nov 28, 2021

WebKit 2.31+ in GNOME SDK (Flatpak)

GNOME Master SDK now includes WebKit.

Nice!

@mirkobrombin mirkobrombin pinned this issue Dec 19, 2021
@pietrodicaprio pietrodicaprio changed the title [Blocked] Move to GTK4 and libadwaita Move to GTK4 and libadwaita Mar 2, 2022
@pietrodicaprio
Copy link
Member

pietrodicaprio commented Mar 2, 2022

libadwaita is now released as stable, documentation available here

@mirkobrombin mirkobrombin moved this to Todo 🎈 in Trento Mar 2, 2022
@mirkobrombin mirkobrombin moved this from Todo 🎈 to Postponed 💭 in Trento Mar 8, 2022
@joaopauloalbq
Copy link

I would like to use Bottles in other interfaces besides GNOME so don't use libadwaita please.

I use Awesome btw

@TheEvilSkeleton
Copy link
Member

TheEvilSkeleton commented Apr 18, 2022

I would like to use Bottles in other interfaces besides GNOME so don't use libadwaita please.

They want to modularize the Bottles backend so other developers can create different front-ends. The fact that it's going to be ported to libadwaita isn't really a problem because you can still change themes. Change the environment variable of GTK_THEME to the theme you want, and it should pick it up. A better solution is using this libadwaita-theme-changer.

Either way, once it's modularized, we might see TUI or Qt front-ends. Perhaps a different GTK front-end too.

@joaopauloalbq
Copy link

I think it's better a GUI that adapts to all interfaces, but different front-ends also solve the problem.

@jannuary
Copy link
Contributor

You're free to make one that "adapts to all interfaces" :)

@naipotato
Copy link
Contributor

You can't have a GUI that can adapt to all existing HIGs: either you choose one or you choose none. Bottles had already adopted GNOME HIGs (headerbars, boxed lists, etc.), so the jump to libadwaita is natural

@mirkobrombin
Copy link
Member Author

I think it's better a GUI that adapts to all interfaces, but different front-ends also solve the problem.

I understand what you are saying and it would be really very nice but also very complex, certainly not impossible. Unfortunately, however, we do not have the effort to accept this challenge and we prefer to focus on things that are more important to us, such as:

  • GTK4 porting
  • software compatibility
  • layers
  • library mode
  • steam proton prefixes
  • improve the versioning tool
  • improve the backup system
  • improve the backend to split out all the bottles stuff from the main manager
  • improve steam deck support with library links
  • moving desktop entries to the new bottles cli
  • splitting out the backend from the frontend, so other developers can make a Qt port without using our cli has a backend

@joaopauloalbq
Copy link

You can't have a GUI that can adapt to all existing HIGs: either you choose one or you choose none

Drawing by maoschanz did a good job of adapting to different interfaces.

@joaopauloalbq
Copy link

I understand what you are saying and it would be really very nice but also very complex, certainly not impossible. Unfortunately, however, we do not have the effort to accept this challenge and we prefer to focus on things that are more important to us

I understand, it is understandable to choose just one HIG, certainly more complex to achieve this visual consistency with other environments.

@mirkobrombin
Copy link
Member Author

I understand what you are saying and it would be really very nice but also very complex, certainly not impossible. Unfortunately, however, we do not have the effort to accept this challenge and we prefer to focus on things that are more important to us

I understand, it is understandable to choose just one HIG, certainly more complex to achieve this visual consistency with other environments.

This is why we are moving the backend out, so other developers can make a new frontend using qt or any other. Also other gtk client for xfce etc

@mirkobrombin mirkobrombin removed the status in Trento Apr 20, 2022
@mirkobrombin mirkobrombin moved this to Todo 🎈 in Trento Apr 20, 2022
@GeorgesStavracas
Copy link

Just found this issue, and I'd like to let you all know:

Vte doesn't support GTK4 (needed by EasyTerm)

VTE has a build flag to build against GTK4 these days. There is a lot to improve in the GTK4 version, but it works and you can already use it.

@mirkobrombin mirkobrombin removed this from Trento Jun 7, 2022
@mirkobrombin mirkobrombin moved this to In Progress ⏱ in Brescia Jun 7, 2022
@mirkobrombin mirkobrombin added this to the 2022.6.14 milestone Jun 7, 2022
Repository owner moved this from In Progress ⏱ to Done ✅ in Brescia Jun 9, 2022
@mirkobrombin mirkobrombin unpinned this issue Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants