Pass combine_attrs arguments for compatibility with xarray-0.18; bump to xarray-0.17.0, Python 3.7
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnomotani
changed the title
combine_attrs arguments for compatibilty with xarray-0.18; bump to xarray-0.17.0, Python 3.7combine_attrs arguments for compatibility with xarray-0.18; bump to xarray-0.17.0, Python 3.7
johnomotani
force-pushed
the
xarray-0.18-compatibility
branch
from
5577aab to
3433d62
Compare
xarray>=0.17.0 is required to use combine_attrs="drop_conflicts". xarray-0.17.0 does not support Python-3.6, so increase minimum Python version to 3.7.
johnomotani
force-pushed
the
xarray-0.18-compatibility
branch
from
3433d62 to
becd461
Compare
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 74.61% 74.61%
=======================================
Files 14 14
Lines 2600 2600
Branches 617 617
=======================================
Hits 1940 1940
Misses 428 428
Partials 232 232
Continue to review full report at Codecov.
|
ZedThree
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to pass
combine_attrsarguments explicitly in a couple of places, otherwise tests fail with the most recent release ofxarray. The new arguments require bumping the minimum supported version ofxarrayto 0.17.0, which requires bumping the minimum Python version to 3.7.