Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute conflict from non-removed "regions" in BoutDataArray.ddy() #222

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

johnomotani
Copy link
Collaborator

No description provided.

@johnomotani johnomotani added the bugfix Fix for a bug label Oct 6, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #222 (7e6c092) into master (943d4fb) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage   75.41%   75.34%   -0.07%     
==========================================
  Files          14       14              
  Lines        2652     2645       -7     
  Branches      625      626       +1     
==========================================
- Hits         2000     1993       -7     
+ Misses        421      420       -1     
- Partials      231      232       +1     
Impacted Files Coverage Δ
xbout/boutdataarray.py 77.87% <50.00%> (+0.73%) ⬆️
xbout/plotting/animate.py 45.21% <0.00%> (-0.87%) ⬇️
xbout/utils.py 82.73% <0.00%> (-0.30%) ⬇️
xbout/boutdataset.py 75.36% <0.00%> (-0.25%) ⬇️
xbout/calc/tests/test_turbulence.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 943d4fb...7e6c092. Read the comment docs.

@johnomotani johnomotani merged commit 38ab417 into master Oct 6, 2021
@johnomotani johnomotani deleted the fix-ddy-attr-conflict branch October 6, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants