-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check whether the grid is the one from the simulation #246
Conversation
Hello @dschwoerer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-09-09 20:09:05 UTC |
45b6a4e
to
b83c414
Compare
That was actually changed by black. I can also remove the comment, but thought the it might be useful if we ever want to add static typing infos |
We should turn off that flake8 warning, and let black handle line length |
We have, but flake8-5.0.x seems to be ignoring the config in our Edit: sorry, rather we've set flake8 to use the same line length as black, but you do have a point as there are some situations where black allows a line length >88 (e.g. in comments) that flake8 complains about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like this 👍
Co-authored-by: John Omotani <[email protected]>
Thanks for the fixes 👍 |
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
- Coverage 73.99% 73.81% -0.18%
==========================================
Files 13 13
Lines 2507 2517 +10
Branches 596 608 +12
==========================================
+ Hits 1855 1858 +3
- Misses 431 435 +4
- Partials 221 224 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
https://docs.python.org/3/library/exceptions.html#ValueError Co-authored-by: John Omotani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dschwoerer!
No description provided.