Do not call mlab.figure() if mayavi_figure_args=None #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a headless machine (e.g. a CI server), calling mlab.figure() causes mayavi to error. This change allows plot3d() to run with mayavi without calling mlab.figure().
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 68.99% 69.01% +0.02%
==========================================
Files 15 15
Lines 3209 3208 -1
Branches 790 790
==========================================
Hits 2214 2214
+ Misses 733 732 -1
Partials 262 262
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I thought this PR was required for boutproject/xBOUT-examples#16, but that test seems to be working with the released version of xBOUT, so apparently this change was not necessary. It should not hurt anyway, so does not seem worth reverting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a headless machine (e.g. a CI server), calling mlab.figure() causes mayavi to error. This change allows plot3d() to run with mayavi without calling mlab.figure().