Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use lower-case for package name #174

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Conversation

localheinz
Copy link
Contributor

This PR

  • uses lower-case for the package name in composer.json

πŸ’β€β™‚οΈ Following an update of composer to 1.8.1, the following message is emitted when running related composer commands

Deprecation warning: require-dev.mikey179/vfsStream is invalid, it should not contain uppercase
characters. Please use mikey179/vfsstream instead. Make sure you fix this as Composer 2.0 will error.

For reference, see https://github.com/composer/composer/releases/tag/1.8.1.

@dereuromark
Copy link

Yeah please fix this! πŸ‘

@QWp6t
Copy link

QWp6t commented Mar 18, 2019

Dupe of #137

@glennmcewan
Copy link

@QWp6t #137 would be a breaking change, but as Composer will use case-insensitive lookups, #174 is backwards compatible.

@SpacePossum
Copy link

@mikey179 anything people can do to help out for processing this PR?

@allejo
Copy link
Member

allejo commented Mar 18, 2019

@SpacePossum see #175

@localheinz
Copy link
Contributor Author

Thank you!

@temp
Copy link

temp commented Apr 16, 2019

With 1.6.6 I'm still getting this error. Shouldn't this be fixed? Or is anything else needed for this to work?

$ cd test
$ ls
$ composer clear-cache
Clearing cache (cache-vcs-dir): /Users/swentz/.composer/cache/vcs
Clearing cache (cache-repo-dir): /Users/swentz/.composer/cache/repo
Clearing cache (cache-files-dir): /Users/swentz/.composer/cache/files
Clearing cache (cache-dir): /Users/swentz/.composer/cache
All caches cleared.
$ composer require mikey179/vfsstream
Using version ^1.6 for mikey179/vfsStream
./composer.json has been created
Deprecation warning: require.mikey179/vfsStream is invalid, it should not contain uppercase characters. Please use mikey179/vfsstream instead. Make sure you fix this as Composer 2.0 will error.
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Installing mikey179/vfsstream (v1.6.6): Downloading (100%)
Writing lock file
Generating autoload files
Changelogs summary:

 - mikey179/vfsstream installed in version v1.6.6
   Release notes: https://github.com/bovigo/vfsStream/releases/tag/v1.6.6

$ composer show
Deprecation warning: require.mikey179/vfsStream is invalid, it should not contain uppercase characters. Please use mikey179/vfsstream instead. Make sure you fix this as Composer 2.0 will error.
mikey179/vfsStream v1.6.6 Virtual file system to mock the real file system in unit tests.

@dereuromark
Copy link

@temp Your own composer file most likely has the wrong name in there, right?

@temp
Copy link

temp commented Apr 16, 2019

@dereuromark Please take a look at the log I provided - it's an empty dir, with the only package I require being vfsstream (composer require mikey179/vfsstream).

@dereuromark
Copy link

What is inside your composer.json file after install?

@temp
Copy link

temp commented Apr 16, 2019

Uppercase:

$ cat composer.json
{
    "require": {
        "mikey179/vfsStream": "^1.6"
    }
}

@dereuromark
Copy link

See :) fix it manually and it will go away.

@temp
Copy link

temp commented Apr 16, 2019

Fixing it by hand and running composer update seems to fix it. But I don't know why it says vfsStream in the first place.

@nicwortel
Copy link

nicwortel commented Apr 30, 2019

I'm running into this as well, it seems like Packagist still knows this package as mikey179/vfsStream: https://packagist.org/packages/mikey179/vfsStream.

I'm not sure how to fix this, maybe pressing the "update" button on Packagist makes Packagist parse the composer.json again?

@dereuromark
Copy link

If this is a composer issue, maybe it is worth escalating it into a ticket there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.