Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ios9 #132

Closed
wants to merge 1 commit into from
Closed

add ios9 #132

wants to merge 1 commit into from

Conversation

orcaman
Copy link

@orcaman orcaman commented Apr 15, 2016

No description provided.

@orcaman
Copy link
Author

orcaman commented Apr 15, 2016

hmm.. seems like the build fails. it doesn't like the fact that I'm calling the version 9.0.0 (expects 9.0).

Also it says it's not expecting "version", but I only have "osversion" - any idea?

@lancedikson
Copy link
Collaborator

@orcaman, ok, looks like the script wanna see something like that: iPhone OS 9_0_0. Is it a real UA? I mean, have you ever seen UA that contains iPhone OS 9_0 (with only a zero)? And of course, the version property will contain 9.0 because of your UA has Version/9.0 substring.

However, we are thinking to change iOS browser detection in future, look at #111 for information.

@orcaman
Copy link
Author

orcaman commented Apr 16, 2016

@lancedikson yup, my iPhone reported that at a certain point, and I found it here as well.

Regarding the future plans for iOS detection, what do you suggest? I don't mind closing the PR if you think it's the way to go, however I can tell you that in my case if it weren't for this commit I wouldn't be able to use bowser.

@lancedikson
Copy link
Collaborator

lancedikson commented Apr 16, 2016

@orcaman, I got it. There is a simple solution of the problem: in cases like you have sent with iPhone OS 9_0 in UA bowser's result would contain the version property with a value 9.0 (not 9.0.0). And this is the most suitable solution as I think. If you are agree with me, don't close it, I'm merging it for the next minor release. Anyway you can suggest another solution :)

Future plans are to detect the real browser name and version on iOS devices. Now as you know name of the browser is a kind of iOS device (iPhone, iPod, iPad), but would be better a real browser name (Safari, Chrome, Opera Coast, etc). But don't think about that right now, it's just a feature request that discussed in #111.

@orcaman
Copy link
Author

orcaman commented Apr 21, 2016

@lancedikson sounds good. I'll make the change

@lancedikson lancedikson added this to the 1.1.1 milestone May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants