-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support QQ Browser #362
Support QQ Browser #362
Conversation
Pull Request Test Coverage Report for Build 724
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll release it this week.
Well thank you! 🙌 |
Hi @lancedikson! No pressure, just a little reminder for you and I hope that you will find the time to merge PRs soon. 😇I appreciate your work on this library. Thank you! |
@mk-kialo, sorry, busy days. Will release it today, promise :) |
Has been released as 2.7.0 :) |
Thanks a lot! 🙌 |
in parser-browsers.js , QQ Browser named but in constants.js,the BROWSER_ALIASES_MAP's key is does it intentionally ? |
@weixublog yes! the browser aliases are just different names for the same thing, but shorter. See the other aliases defined such as |
in BROWSER_MAP
but in it's aliases
it's different ... maybe, we should use |
This adds support for the QQ Browser (Windows, macOS, Android, iOS) and QQ Browser Lite a.k.a. QQ Browser for Mac (macOS).
Note that the "Browser" in the name is relevant, as there is a different program called simply "QQ" (an instant messenger) which can also act as a browser.