Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Benchmarks workflow #1458

Merged
merged 11 commits into from
Aug 24, 2024
Merged

Add Benchmarks workflow #1458

merged 11 commits into from
Aug 24, 2024

Conversation

sudo-jarvis
Copy link
Contributor

@sudo-jarvis sudo-jarvis commented Aug 16, 2024 •
edited by github-actions bot
Loading

@sudo-jarvis
Copy link
Contributor Author

sudo-jarvis commented Aug 22, 2024 •
edited
Loading

@Julian Looks like there is a vulnerability in the npm package micromatch because of which the audit test is failing . The version 4.0.7 which we are using seems to be the latest version only.

@Julian
Copy link
Member

Julian commented Aug 22, 2024

It looks like from GHSA-952p-6rrq-rcjv that the CVE is misdeclared (it considers 4.0.6 vulnerable) so we can't even downgrade while making it go away (so there's nothing to do until that's fixed in the database, which it looks like is in progress).

@Julian Julian merged commit 8787139 into bowtie-json-schema:main Aug 24, 2024
25 checks passed
@sudo-jarvis
Copy link
Contributor Author

Hey @Julian , can you do a release for bowtie and then run the benchmarks workflow for the first time? Or else the reports workflow would fail as currently we have no artifact as this workflow has never been run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julian Julian Julian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudo-jarvis @Julian