Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for filtering groups by name #757

Merged
merged 6 commits into from
Feb 19, 2021
Merged

Add support for filtering groups by name #757

merged 6 commits into from
Feb 19, 2021

Conversation

sujaygarlanka
Copy link
Contributor

@sujaygarlanka sujaygarlanka commented Feb 18, 2021 •
edited
Loading

Goals ⚽

  • Update listEnterpriseGroups() to use documented parameter for filtering by name

Implementation Details 🚧

  • Change undocumented name key to documented filter_term because they both do the same thing

Testing Details 🔍

  • None

swfree
swfree previously approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@swfree swfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since test coverage fell, maybe add a unit test for listForEnterprise to GroupsModuleSpecs.swift?

@sujaygarlanka sujaygarlanka merged commit 1e99cdd into master Feb 19, 2021
@sujaygarlanka sujaygarlanka deleted the filter-term-groups branch February 19, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJSimon PJSimon PJSimon approved these changes

@swfree swfree swfree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sujaygarlanka @PJSimon @swfree