Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional details field for Event #770

Merged
merged 6 commits into from
Apr 20, 2021
Merged

Add additional details field for Event #770

merged 6 commits into from
Apr 20, 2021

Conversation

sujaygarlanka
Copy link
Contributor

Goals ⚽

  • Add additional details field for Event model

Implementation Details 🚧

  • Add field
  • Change access modifiers for two decoding methods

Testing Details 🔍

  • Added to existing deserialization test

@swfree swfree merged commit 38d72fd into main Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swfree swfree swfree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sujaygarlanka @swfree