test(cypress): Add support for integration tests via cypress #732
Conversation
|
Verified that @jstoffan has signed the CLA. Thanks for the pull request! |
|
This is great! |
test/cypress/integration/ContentExplorer/ContentExplorer.spec.js
Outdated
Show resolved
Hide resolved
| @@ -50,6 +50,9 @@ | |||
| "build:prod:npm": "BABEL_ENV=production OUTPUT=dist LANGUAGE=en-US REACT=true yarn build:prod:dist", | |||
| "clean": "rm -rf dist lib i18n/json i18n/*.js reports styleguide", | |||
| "copy:styles": "cpx './src/**/*.scss' lib", | |||
| "cy:open": "yarn cy:wait; cypress open --project ./test", | |||
| "cy:run": "yarn cy:wait; cypress run --project ./test --spec test/cypress/**/*.spec.js", | |||
| "cy:wait": "wait-on tcp:6060", | |||
There was a problem hiding this comment.
Are there any concerns with hardcoding the port? Parallelism issues in Travis maybe?
There was a problem hiding this comment.
This is the hardcoded port of the styleguidist server. There's not really a way around it.
test/cypress.json
Outdated
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "baseUrl": "http://localhost:6060/#", | |||
There was a problem hiding this comment.
Can we use the test folder instead, and inject the access token? This way we can use a non-hardcoded access token which could have additional scopes such as those needed for creating comments.
There was a problem hiding this comment.
The example files accept a token via the TOKEN environment variable.
| @@ -14,7 +14,7 @@ type Props = { | |||
| }; | |||
|
|
|||
| const SidebarContent = ({ actions, title, children }: Props) => ( | |||
| <div className="bcs-content"> | |||
| <div className="bcs-content" data-testid="bcs-content"> | |||
There was a problem hiding this comment.
It seems like we will have to add a bit of these to our code. Can we remove them with something like https://www.npmjs.com/package/babel-plugin-react-remove-properties ?
There was a problem hiding this comment.
We can look into doing so in a follow-up PR. I'd like to avoid transforming the lib/dist output with this change, if possible.
test/cypress/integration/ContentExplorer/ContentExplorer.spec.js
Outdated
Show resolved
Hide resolved
test/cypress/integration/ContentExplorer/ContentExplorer.spec.js
Outdated
Show resolved
Hide resolved
test/cypress/integration/ContentExplorer/ContentExplorer.spec.js
Outdated
Show resolved
Hide resolved
jstoffan
force-pushed
the
cypress
branch
4 times, most recently
from
0f6bdaf to
b9a58c7
Compare
|
🎉 This PR is included in version 8.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This isn't quite ready to merge yet due to some outstanding issues: