Copy stream for upload requests and remove expect header #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove expect header
Change ReusableContent to internal
mhagmajer
previously approved these changes
Aug 5, 2021
PJSimon
reviewed
Aug 6, 2021
mhagmajer
approved these changes
Aug 9, 2021
PJSimon
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream is being closed (disposed) when request is sent by HttpClient. See dotnet/runtime#14612
It was actually resolved in .NET Core (dotnet/corefx#19082), but since we need to support the .NET Framework too, another fix is required.
The drawback of copying stream is that we allocate additional memory for the copied stream (basically stream size is doubled).
Another fix that could be applied instead would be to check if token is valid before making the upload request.