Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing configureAwait(false) when awaiting to prevent deadlocks #775

Merged
merged 4 commits into from
Nov 23, 2021
Merged

fix: add missing configureAwait(false) when awaiting to prevent deadlocks #775

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
817ca61
add missing configure await false
mwwoda Nov 23, 2021
505c613
add configureAwait(false) to missing places
mwwoda Nov 23, 2021
7e991c2
Fix method calls
mwwoda Nov 23, 2021
31188bb
Fix missing places
mwwoda Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Box.V2/Auth/AuthRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public AuthRepository(IBoxConfig boxConfig, IBoxService boxService, IBoxConverte
/// <returns>The session of the Box Client after authentification</returns>
public virtual async Task<OAuthSession> AuthenticateAsync(string authCode)
{
OAuthSession session = await ExchangeAuthCode(authCode);
OAuthSession session = await ExchangeAuthCode(authCode).ConfigureAwait(false);

await _mutex.WaitAsync().ConfigureAwait(false);
// using (await _mutex.LockAsync().ConfigureAwait(false))
Expand Down