-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: upgrade .net framework to 4.6.2, remove deprecated methods, remove use_index
references, return proper object from GetFileVersionsUnderRetentionForAssignmentAsync
#881
+393
−1,010
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
38dc8e7
feat!: upgrade .net framework to 4.6.2 (#863)
mwwoda ab45a79
feat!: remove method with `use_index` reference (#870)
mwwoda 70f7a89
feat!: remove deprecated methods (#874)
mwwoda 8b69de1
fix!: return proper object type from `GetFileVersionsUnderRetentionFo…
mwwoda cd7c51b
chore: ignore `bug fixes` in `readme` during linting (#876)
mwwoda 8ca1958
Merge branch 'main' into version-5
mwwoda 8516efe
Merge branch 'version-5' of https://github.com/box/box-windows-sdk-v2…
mwwoda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
feat!: upgrade .net framework to 4.6.2 (#863)
commit 38dc8e7f1876e3ba43e18526064868dbc1605349
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,8 +6,6 @@ on: | |
- main | ||
pull_request: | ||
types: [opened, synchronize] | ||
branches: | ||
- main | ||
|
||
jobs: | ||
core: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,8 +3,6 @@ name: Lint Code Base | |
on: | ||
pull_request: | ||
types: [opened, synchronize] | ||
branches: | ||
- main | ||
|
||
jobs: | ||
build: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<packages> | ||
<package id="BouncyCastle" version="1.8.9" targetFramework="net45" /> | ||
<package id="Microsoft.IdentityModel.JsonWebTokens" version="6.12.2" targetFramework="net45" /> | ||
<package id="Microsoft.IdentityModel.Logging" version="6.12.2" targetFramework="net45" /> | ||
<package id="Microsoft.IdentityModel.Tokens" version="6.12.2" targetFramework="net45" /> | ||
<package id="Newtonsoft.Json" version="13.0.1" targetFramework="net45" /> | ||
<package id="System.IdentityModel.Tokens.Jwt" version="6.12.2" targetFramework="net45" /> | ||
<package id="BouncyCastle" version="1.8.9" targetFramework="net462" /> | ||
<package id="Microsoft.IdentityModel.JsonWebTokens" version="6.12.2" targetFramework="net462" /> | ||
<package id="Microsoft.IdentityModel.Logging" version="6.12.2" targetFramework="net462" /> | ||
<package id="Microsoft.IdentityModel.Tokens" version="6.12.2" targetFramework="net462" /> | ||
<package id="Newtonsoft.Json" version="13.0.1" targetFramework="net462" /> | ||
<package id="System.IdentityModel.Tokens.Jwt" version="6.12.2" targetFramework="net462" /> | ||
</packages> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
# Upgrading from 4.x.x to 5.x.x | ||
|
||
Follow the [General changes](#general-changes) to see the changes that are package indenpendent. Also refer to the [Box.V2](#box-v2) or | ||
[Box.V2.Core](#box-v2-core) section depending on the package you are using. | ||
|
||
## General changes | ||
|
||
No changes | ||
|
||
## Box.V2 | ||
|
||
### Minimal .NET runtime version upgrade | ||
|
||
If you are still using .NET Framework version lower than 4.6.2 you need to upgrade to the 4.6.2+ version. You can do it by changing target framework in the .csproj file of your project. | ||
|
||
For SDK-style projects | ||
|
||
Before | ||
```xml | ||
<TargetFramework>net45<TargetFramework/> | ||
``` | ||
|
||
After | ||
```xml | ||
<TargetFramework>net462<TargetFramework/> | ||
``` | ||
|
||
See [SDK-style target framework](https://learn.microsoft.com/en-us/dotnet/standard/frameworks) for more information. | ||
|
||
For non SDK-style projects | ||
|
||
Before | ||
```xml | ||
<TargetFrameworkVersion>v4.5</TargetFrameworkVersion> | ||
``` | ||
|
||
After | ||
```xml | ||
<TargetFrameworkVersion>v4.6.2</TargetFrameworkVersion> | ||
``` | ||
|
||
See [MSBuild target framework](https://learn.microsoft.com/en-us/visualstudio/msbuild/msbuild-target-framework-and-target-platform?view=vs-2022) for more information | ||
|
||
We recommend to upgrade to the newest version possible. | ||
See [.NET Framework lifecycle](https://learn.microsoft.com/en-us/lifecycle/products/microsoft-net-framework) | ||
|
||
## Box.V2.Core | ||
|
||
No changes |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason why you keep targeting core beyond EOL? Currently, only net6 and net7 are supported, see here. I'm ignoring the .net framework, haven't worked with it for a few years :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our Box.V2.Core package still targets .NET 2.0 standard, which technically still supports old versions of .NET Core. To reflect that we target these versions in our test projects.
This is a relic from the past. We currently have two packages that we produce from the same code base. One that targets the good old .NET Framework and another that targets .NET Standard (the goal for it is to be used with .NET Core). This is not an ideal scenario, as we could simply have one package that targets .NET Standard because it supports both Core and Framework or target .NET Core explicitly in one of the packages, so we could officially drop support for those old versions and target the current one. This is something we might consider in the future, as it could break some of our clients. We don't use e.g. new language features from newer .NET so I don't think it's super important at the moment.