Implementing task desc croping(cf #27) #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coming back to boxine#27, I had in a middle of a long series of tasks one of them which crashed due to a ValidationError('Process info description overlong'). It reminded me about boxine#27 where I thought we implemented a crop of TaskModel.desc to 64 characters. As stated already at the time. having a desc bigger than 64 char should not for me prevent a task to run. Especially when task description are generated automatically I would therefore suggest implementing the following changes
|
Jens, note that that could lead to a fail of the test you put in place for testing if an error was raised when desc was bigger than 64 However, I don't really understand why an error would be raised on: |
jedie
reviewed
Mar 30, 2022
|
Unclear for me why we should have the error Your help is needed |
|
Need your input @jedie |
jedie
reviewed
Apr 11, 2022
Skrattoune
commented
Apr 18, 2022
jedie
pushed a commit
that referenced
this pull request
Aug 2, 2022
Adopt the idea from #95 and just crop the description and log a warning.
jedie
pushed a commit
that referenced
this pull request
Aug 2, 2022
Adopt the idea from #95 and just crop the description and log a warning.
|
@Skrattoune i used our idea and create: #108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming back to #27,
I had in a middle of a long series of tasks one of them which crashed due to a
ValidationError('Process info description overlong').It reminded me about #27 where I thought we implemented a crop of
TaskModel.descto 64 characters.As stated already at the time, having a desc bigger than 64 char should not for me prevent a task to run.
Especially when task description are generated automatically
I would therefore suggest implementing the following changes