Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UI SDK #2464

Merged
merged 44 commits into from
Mar 28, 2024
Merged

Use UI SDK #2464

merged 44 commits into from
Mar 28, 2024

Conversation

niwsa
Copy link
Member

@niwsa niwsa commented Mar 19, 2024

What does this PR do?

Depends on boxyhq/ui#1065

  • Use Create, Edit components from SDK
  • Routes to be tested for their normal expected flow - SSO, DSync Create/Edit via connections , Settings SSO, Create/Edit SSO/DSync connections via setup links

Type of change

  • Updated dependencies
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Existing unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@niwsa niwsa mentioned this pull request Mar 26, 2024
13 tasks
@niwsa niwsa marked this pull request as ready for review March 26, 2024 18:50
@niwsa niwsa requested a review from a team March 26, 2024 18:57
@ukrocks007
Copy link
Contributor

Screenshot 2024-03-27 at 4 29 57 PM

we should not allow expiry less than equal to 0 right?

@niwsa
Copy link
Member Author

niwsa commented Mar 27, 2024

Will pull in boxyhq/ui#1085 and then merge

@deepakprabhakara deepakprabhakara merged commit 67f1117 into main Mar 28, 2024
5 checks passed
@deepakprabhakara deepakprabhakara deleted the use-ui-sdk branch March 28, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants