Rename event handler prop for Button component

[Ryukemeister]

No description provided.

[niwsa]

Good catch 👍

[niwsa]

Seeing some issues while testing the Connections component with the changes ...

[Ryukemeister]

Seeing some issues while testing the Connections component with the changes ...

Made some tweaks so should hopefully fix the issues now!

[niwsa]

The generated code for "react" at

ui/src/sso/connections/EditConnection/saml/index.lite.tsx

Line 162 in f96f15f

<form onSubmit={state.saveSSOConnection} method='post'>

is not invoking the handler

I guess the takeaway is we should stick to (event) => handler(event) for handlers on native elements like form, input, button etc. So onSubmit={(event) => state.saveSSOConnection(event)} fixes it.

[niwsa]

The vue build shows some errors.

[Ryukemeister]

The generated code for "react" at

ui/src/sso/connections/EditConnection/saml/index.lite.tsx

Line 162 in f96f15f

<form onSubmit={state.saveSSOConnection} method='post'>

is not invoking the handler

I guess the takeaway is we should stick to (event) => handler(event) for handlers on native elements like form, input, button etc. So onSubmit={(event) => state.saveSSOConnection(event)} fixes it.

That's strange because I actually tested that piece and it was working for me but yes better to use (event) => handler(event) there.

[niwsa]

That's strange because I actually tested that piece and it was working for me but yes better to use (event) => handler(event) there.

It's doing a browser submission to the page instead of the API route.