Made repo pip installable #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I appreciate you doing this, I'm leary of taking out the pandas-flavor though, this package is used by py-janitor which is why it was used in the first place. Is this not required anymore with pandas? |
|
@sauhaardac there is a pretty big bug in the descriptastorus on pipy, I'd like to add pushing to pypi as part of my continuous integration. Is it possible to turn control over the pypi repository to me so I can always push new releases? |
|
@bp-kelley Happy to do so! I need your pypi username to be able to do that, could you send that over? If not willing to share here, you can also contact me at "[email protected]" |
|
It's bp-kelley, thanks!
…On Thu, Oct 13, 2022 at 6:23 PM Raunak Chowdhuri ***@***.***> wrote:
@bp-kelley <https://github.com/bp-kelley> Happy to do so! I need your
pypi username to be able to do that, could you send that over? If not
willing to share here, you can also contact me at ***@***.***"
—
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLOFICTQ5R43MPOKKPQ2ZTWDCDWFANCNFSM557F77BA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sent the invite!
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Rdkit is now available on PYPI, I made this project pip installable and uploaded it on PYPI myself:
https://pypi.org/project/descriptastorus/
If you would like to merge this PR and upload the project to PYPI on your own account, I will happily take down my PYPI project so you can do so.