Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize unchecked scope. Avoid StringBuilder in logging #87

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

errael
Copy link
Contributor

@errael errael commented Mar 18, 2021

Address my latest cause, unchecked scope. Get rid of "+" in logger.debug() to avoid creating StringBuilder when logging not enabled.

@errael errael requested a review from bpangburn March 18, 2021 20:10
@bpangburn bpangburn merged commit 734b2e1 into 4.0.4-SNAPSHOT Mar 19, 2021
@errael errael deleted the UncheckedAndLogging branch March 19, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants