Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to chrome headless #30

Merged
merged 9 commits into from
Sep 2, 2022
Merged

Migrate to chrome headless #30

merged 9 commits into from
Sep 2, 2022

Conversation

barmac
Copy link
Member

@barmac barmac commented Sep 2, 2022 •
edited
Loading

This PR:

  • migrates project to use puppeteer and chrome headless instead of phantomjs
  • sets up linting
  • updates package-lock to v2
  • replaces most of setTimeout in tests with load event listeners
  • adds debug logging
  • makes sure we correctly handle messages from test browser
  • introduces a temporary workaround for modeling#setColor sets color on BPMNPlane bpmn-js#1734
  • updates dependencies to remove detected vulnerabilities

Closes #24

@barmac barmac requested review from nikku and marstamm September 2, 2022 12:58
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 2, 2022
@barmac barmac requested a review from philippfromme September 2, 2022 13:03
nikku
nikku approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified it works. Good stuff!

@fake-join fake-join bot merged commit 430c700 into master Sep 2, 2022
@fake-join fake-join bot deleted the 24-migrate-to-chrome-headless branch September 2, 2022 14:07
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@marstamm marstamm Awaiting requested review from marstamm

@philippfromme philippfromme Awaiting requested review from philippfromme

Assignees

@barmac barmac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop PhantomJS and use modern browsers instead
2 participants
@barmac @nikku