Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transforming a Call Activity into a SubProcess does not resize the Shape #1687

Closed
pihme opened this issue Jun 27, 2022 · 4 comments · Fixed by #1720
Closed

Transforming a Call Activity into a SubProcess does not resize the Shape #1687

pihme opened this issue Jun 27, 2022 · 4 comments · Fixed by #1720
Assignees
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@pihme
Copy link

pihme commented Jun 27, 2022

Describe the Bug

There is a certain edit sequence which is a little confusing because it leads to what seems like a dead end.

Steps to Reproduce

  1. Create Camunda 8 BPMN diagram
  2. Create a task
  3. Use wrench symbol to turn the task into a call activity
  4. Now observe, that the wrench menu has additional entries (which is already a bit confusing): sub-process collapsed, sub-process expanded
  5. Use wrench symbol to turn the call activity into an expanded sub process
  6. Now you end up with an element that visually looks like a task. But when opening the wrench menu, it only allows me to change it into an event subprocess. So I cannot go back to turn it into a call activity, and I reached a dead end.

image

Hints:

  • I was unable to reproduce this exactly on demo.bpmn.io
  • Was able to reproduce it in current web modeler
  • Was able to reproduce it in desktop modeler 5.0.0

Expected Behavior

  • after step 3, I don't expect additional entries to appear in the wrench menu. Especially since it seems that the collapsed sub process is not fully supported UI wise in either desktop or web modeler.
  • When I use the wrench symbol to change the type of an element, I expect that I can use the same wrench symbol to change the type back

Environment

  • Browser: Firefox
  • OS: Ubuntu 21.04
  • Library version: Whatever is used by current web modeler and desktop modeler 5.0.0
@pihme pihme added the bug Something isn't working label Jun 27, 2022
@pinussilvestrus
Copy link
Contributor

@marstamm is this related to #1688?

@marstamm
Copy link
Contributor

This is a different problem, I'm not sure if we already have an open issue for it. I'm sure I saw it before but can't find an issue.

Problem:

  • Subprocess auto Resizing is only enabled for Tasks
  • a CallActivity is not a Task
  • The Subprocess keeps original dimensions

You are able to resize this Subprocess manually
Recording 2022-07-15 at 13 17 05

@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Jul 15, 2022

Moving this to backlog then. Feel free to disagree and move it to ready.

@pinussilvestrus pinussilvestrus added backlog Queued in backlog spring cleaning Could be cleaned up one day labels Jul 15, 2022
@marstamm marstamm changed the title Edit sequence that leads to a bit of a dead end Transforming a Call Activity into a SubProcess does not resize the Shape Jul 15, 2022
@philippfromme philippfromme self-assigned this Aug 19, 2022
@philippfromme philippfromme added in progress Currently worked on and removed backlog Queued in backlog labels Aug 19, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 19, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 19, 2022
@philippfromme
Copy link
Contributor

Fixed by #1720.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants