Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection lines follow element shape #1996

Closed
smbea opened this issue Oct 25, 2023 · 0 comments · Fixed by #1998
Closed

Selection lines follow element shape #1996

smbea opened this issue Oct 25, 2023 · 0 comments · Fixed by #1998
Assignees
@smbea

Comments

@smbea
Copy link
Contributor

smbea commented Oct 25, 2023

What should we do?

Selection lines follow element shape instead of always being square.

Screen.Recording.2023-10-17.at.22.06.23.mov

See Prototype: https://philippfrom.me/hackdays-2023/

Why should we do it?

Part of canvas rework effort, see https://github.com/camunda/product-hub/issues/1653
@smbea smbea added the ready Ready to be worked on label Oct 25, 2023
@smbea smbea self-assigned this Oct 25, 2023
@smbea smbea mentioned this issue Oct 25, 2023
Closed
smbea added a commit to bpmn-io/diagram-js that referenced this issue Oct 25, 2023
@smbea
feat: support outline providers
a58d91c 
Related to bpmn-io/bpmn-js#1996
smbea added a commit that referenced this issue Oct 25, 2023
@smbea
wip: provide selection outlines
b159cc6 
Closes #1996
@smbea smbea mentioned this issue Oct 25, 2023
Merged
smbea added a commit to bpmn-io/diagram-js that referenced this issue Oct 26, 2023
@smbea
feat: support outline providers
d6cd1c1 
Related to bpmn-io/bpmn-js#1996
smbea added a commit to bpmn-io/diagram-js that referenced this issue Oct 26, 2023
@smbea
feat: support outline providers
5e165f1 
Related to bpmn-io/bpmn-js#1996
smbea added a commit to bpmn-io/diagram-js that referenced this issue Oct 26, 2023
@smbea
feat: support outline providers
e2c5e1f 
Related to bpmn-io/bpmn-js#1996
smbea added a commit that referenced this issue Oct 30, 2023
@smbea
wip: provide selection outlines
984560c 
Closes #1996
smbea added a commit to bpmn-io/diagram-js that referenced this issue Oct 30, 2023
@smbea
feat: support outline providers
7795cb0 
Related to bpmn-io/bpmn-js#1996
philippfromme pushed a commit to bpmn-io/diagram-js that referenced this issue Oct 30, 2023
@smbea @philippfromme
feat: support outline providers
f776ade 
Related to bpmn-io/bpmn-js#1996
philippfromme pushed a commit to bpmn-io/diagram-js that referenced this issue Oct 30, 2023
@smbea @philippfromme
feat: support outline providers
2b01eca 
Related to bpmn-io/bpmn-js#1996
smbea added a commit that referenced this issue Oct 30, 2023
@smbea
feat: provide selection outlines
ec6f252 
Closes #1996
smbea added a commit that referenced this issue Oct 30, 2023
@smbea
feat: provide selection outlines
34b37f3 
Closes #1996
smbea added a commit that referenced this issue Oct 30, 2023
@smbea
feat: provide selection outlines
390f713 
Closes #1996
@smbea smbea mentioned this issue Oct 30, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on needs review Review pending and removed ready Ready to be worked on in progress Currently worked on labels Oct 30, 2023
smbea added a commit that referenced this issue Oct 31, 2023
@smbea
feat: provide selection outlines
a594cfe 
Closes #1996
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Oct 31, 2023
smbea added a commit that referenced this issue Oct 31, 2023
@smbea
feat: provide selection outlines
1126806 
Closes #1996
smbea added a commit that referenced this issue Oct 31, 2023
@smbea
feat: provide selection outlines
3dc9a27 
Closes #1996
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 31, 2023
barmac pushed a commit that referenced this issue Oct 31, 2023
@smbea @barmac
feat: provide selection outlines
c3fed8e 
Closes #1996
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 31, 2023
@barmac barmac mentioned this issue Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smbea smbea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated outlines bpmn-io/bpmn-js
1 participant
@smbea