Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replace): create bpmn:LinkEventDefinition with empty name #1297

Merged
merged 2 commits into from
Mar 27, 2020
Merged

feat(replace): create bpmn:LinkEventDefinition with empty name #1297

merged 2 commits into from
Mar 27, 2020

Conversation

nikku
Copy link
Member

@nikku nikku commented Mar 26, 2020

Closes #1296

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 26, 2020
@barmac barmac self-requested a review March 27, 2020 06:20
barmac
barmac requested changes Mar 27, 2020
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that BpmnReplace is ignoring the new attributes. I pushed two test cases revealing buggy behavior.

@nikku nikku force-pushed the link-event-name branch from 0c00165 to 69a7925 Compare March 27, 2020 07:13
@nikku nikku requested a review from barmac March 27, 2020 07:16
@nikku
Copy link
Member Author

nikku commented Mar 27, 2020

Thanks for the better test cases verifying the behavior!

Ready for round 2️⃣ of review.

barmac
barmac approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fake-join fake-join bot merged commit c2ded39 into develop Mar 27, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 27, 2020
@fake-join fake-join bot deleted the link-event-name branch March 27, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link Events are missing the name attribute
2 participants
@nikku @barmac