Resurrect translation reporter #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores the translation reporter that allows us to extract translations from the library, as we test it.
Remove modeling feedback on paste rejected. That event is long gone, as we two-step copy and paste nowadays.
nikku
requested review from
a team,
barmac and
MaxTru
and removed request for
a team
barmac
reviewed
Nov 3, 2020
| "Exclusive Gateway", | ||
| "HELLO {you}!", |
MaxTru
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1356
This restores a translation reporter that we had in good old grunt times to collect translatable strings. The PR also makes sure we cover a few more existing functions, added a bunch of new tests accordingly.