fix(modeling): set label color on bpmndi:BPMNLabel#color
#1543
+125
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's probably unrelated but might have been broken in one of recent releases. When I create a new connection, its DI contains empty "waypoints" attribute: <bpmndi:BPMNEdge id="Flow_0o53f0k_di" bpmnElement="Flow_0o53f0k" waypoints="">
<di:waypoint x="215" y="97" />
<di:waypoint x="272" y="97" />
</bpmndi:BPMNEdge> |
|
Hmm this could be merged to |
|
My bad (not merging to master). Will likely cherry-pick. |
|
How can I reproduce #1543 (comment)? This is a serious regression, if reproducible, that we shall look into, too. |
I've created an issue which links to a branch with a test case: #1544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting colors on external labels would not set the
bpmndi:BPMNLabel#colorproperty but rather serialize it illegally asbpmndi:BPMNEdge#background-color. This PR fixes the behavior to adopt the standards compliant serialization.Note that we already support reading color in the correct way, cf.
BpmnRenderer.Related to camunda/camunda-modeler#2599.